search

vonovak / react-native-add-calendar-event

Create, view or edit events in react native using the standard iOS / Android dialogs
MIT License
342 stars 103 forks source link

report from production :) #3

Open mordaha opened 7 years ago

mordaha commented 7 years ago

  1. IOS - Case: You have 1 or more shared calendars (in your Calendar App). When you try to select another calendar (than default) when creating event - app crashes. It is because app wanna access to Contacts (?) and needs description in NSContactsUsageDescription to ask such permissions. After adding NSContactsUsageDescription, app (lib) doesn't crash and function normally after asking permission in ether granted or not granted result of request.

  2. IOS - without NSContactsUsageDescription (and without asking about access to Contacts) - when create event dialog popped it is possible to add members to created event from your Contacts. With NSContactsUsageDescription added it is possible only when permission to Contacts granted. (it this an ios bug? ¯_(ツ)_/¯)

  3. Android - on all androids (prior 5.0 and aft) it is sufficient to grant only WRITE_CALENDAR permission to create events - except for any SONY phone (we have in our testing team). Sony phones requires READ_CALENDAR permission both with old 4.x and new (5..7) Android on board. App doesn't crashes, not it receives any exception - but without READ permission event in calendar is not creating. The need of such permission (READ) shows on old androids a weird message before installation about "this app can read and delete all your private calendars on this device".

Proposals: do not pop alerts from library (ios), exceptions are sufficient enough. This is because of need to show localized alert to user from app. I can send PR for this.

vonovak commented 7 years ago

thanks @mordaha, great to see the lib being used, those are some really interesting observations! If you could ship over a PR, I'd appreciate it!