vonovak / react-native-theme-control

Natively control react native application theme at runtime and persist it for the next app start.
MIT License
158 stars 5 forks source link

Android builds with Expo 49 fail #11

Closed Armster15 closed 1 year ago

Armster15 commented 1 year ago

First off, thank you so much for building this. I've been looking for something like this for quite some time. The library works perfectly fine for me for Expo iOS builds, but for me Android builds fail.

Here is a base repository where you can reproduce the error: https://github.com/Armster15/theme-control-reproducible/

To note, I am using Expo 49 with React Native 72.

Steps to reproduce

  1. Create a new expo app with create-expo-app. I used Yarn v1 for the package manager but I don't think it should make a difference.
  2. Install @vonovak/react-native-theme-control and expo-system-ui (the latter is required in order for Expo to recognize the userInterfaceStyle property in app.json)
  3. In app.json, update the value of the userInterfaceStyle property to be automatic
  4. Create a plugins property, where the value is ["@vonovak/react-native-theme-control"]
  5. Run yarn expo run:android to trigger a build
  6. See the following error:
    
    > Task :vonovak_react-native-theme-control:packageDebugResources FAILED

FAILURE: Build failed with an exception.

Once again, thank you so much for this awesome library!

vonovak commented 1 year ago

Hello and thanks for reporting, Thank you for your kind words and for including a runnable reproduction! 💯 I don't see that nearly enough 🙈 😄 . The issue should be fixed in the next version.

Thank you 🙂

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 4.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: