Closed Armster15 closed 1 year ago
Hello and thanks for reporting, Thank you for your kind words and for including a runnable reproduction! đŻ I don't see that nearly enough đ đ . The issue should be fixed in the next version.
Thank you đ
:tada: This issue has been resolved in version 4.1.2 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
First off, thank you so much for building this. I've been looking for something like this for quite some time. The library works perfectly fine for me for Expo iOS builds, but for me Android builds fail.
Here is a base repository where you can reproduce the error: https://github.com/Armster15/theme-control-reproducible/
To note, I am using Expo 49 with React Native 72.
Steps to reproduce
create-expo-app
. I used Yarn v1 for the package manager but I don't think it should make a difference.@vonovak/react-native-theme-control
andexpo-system-ui
(the latter is required in order for Expo to recognize theuserInterfaceStyle
property in app.json)userInterfaceStyle
property to beautomatic
plugins
property, where the value is["@vonovak/react-native-theme-control"]
yarn expo run:android
to trigger a buildFAILURE: Build failed with an exception.
What went wrong: Some problems were found with the configuration of task ':vonovak_react-native-theme-control:packageDebugResources' (type 'MergeResources').
Reason: Task ':vonovak_react-native-theme-control:packageDebugResources' uses this output of task ':vonovak-react-native-theme-control:compileDebugRenderscript' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
Possible solutions:
Please refer to https://docs.gradle.org/8.0.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
Reason: Task ':vonovak_react-native-theme-control:packageDebugResources' uses this output of task ':vonovak-react-native-theme-control:generateDebugResValues' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
Possible solutions:
Please refer to https://docs.gradle.org/8.0.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
Once again, thank you so much for this awesome library!