search

vonovak / react-navigation-header-buttons

Easily render header buttons for react-navigation
MIT License
893 stars 65 forks source link

Misc Typescript fixes #250

Closed bekatru closed 1 week ago

bekatru commented 1 week ago

Discovered that index file does not support isolatedModules Also, UIManager might not contain a method. Added a check for that too. 

node_modules/react-navigation-header-buttons/src/index.ts:1:10 - error TS1205: Re-exporting a type when 'isolatedModules' is enabled requires using 'export type'.

1 export { HeaderButtonsComponentType } from './HeaderButtonComponentContext';
           ~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/react-navigation-header-buttons/src/index.ts:9:25 - error TS1205: Re-exporting a type when 'isolatedModules' is enabled requires using 'export type'.

9 export { HeaderButtons, HeaderButtonsProps } from './HeaderButtons';
                          ~~~~~~~~~~~~~~~~~~

node_modules/react-navigation-header-buttons/src/index.ts:17:3 - error TS1205: Re-exporting a type when 'isolatedModules' is enabled requires using 'export type'.

17   OnOverflowMenuPressParams,
     ~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/react-navigation-header-buttons/src/overflowMenu/overflowMenuPressHandlers.ts:90:31 - error TS2339: Property 'showPopupMenu' does not exist on type 'UIManagerStatic'.

90   const presenter = UIManager.showPopupMenu;
                                 ~~~~~~~~~~~~~

node_modules/react-navigation-header-buttons/src/overflowMenu/vendor/Menu.tsx:254:25 - error TS2584: Cannot find name 'document'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.

254     this.isBrowser() && document.addEventListener('keyup', this.handleKeypress);
                            ~~~~~~~~

node_modules/react-navigation-header-buttons/src/overflowMenu/vendor/Menu.tsx:262:7 - error TS2584: Cannot find name 'document'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.

262       document.removeEventListener('keyup', this.handleKeypress);
          ~~~~~~~~