vonshednob / pter

Manage your todo.txt in a commandline user interface (TUI)
https://vonshednob.cc/pter/
MIT License
102 stars 6 forks source link

Patch: UI proofreading/minor editing #54

Closed andrei-a-papou closed 5 months ago

andrei-a-papou commented 6 months ago

I've made several patches to fix some inconsistencies in UI strings as well as offer several improvements. Labels now consistently use sentence-case capitalization (first letter only). Some labels have been shortened: I think it's generally a good idea, plus (depending on the terminal geometry and font size) some labels in the Help bar may not fit on screen otherwise.

Some changes may be a bit opinionated though I've tried to avoid these :) Please let me know your thoughts.

99-new-strings-1.diff.gz 99-new-strings-2.diff.gz 99-new-strings-3.diff.gz

andrei-a-papou commented 6 months ago

In addition, in my local repo I've removed the "fancy" return character from the UI. Personally, I prefer the UI to say <return> as it's easier to read (at least with the font I use). But the real reason is consistency: right now, some UI parts say and some say <return>, which I think we should correct either way :) As long as it's consistent, you have my vote :)

99-remove-fancy-return-key.diff.gz

vonshednob commented 6 months ago

I full agree: consistency! And not everyone might understand the symbols (especially when it comes to the more obscure ones, like for page down)

andrei-a-papou commented 6 months ago

Yes, but I like the arrow key symbols -- these are intuitive and helpful

vonshednob commented 6 months ago

So … partial consistency? UX is not an area where I have a lot of experience. I'm very happy about any advise.

andrei-a-papou commented 6 months ago

No, you're right. Sorry for a confusing remark. We need consistency throughout. Right now we have <up> on the Help screen, but in the Helpbar. Load search dialog uses , but New task dialog uses <return>.

With the current keys, I don't see a real need the "human-friendly" key translations (under SPECIAL = {}) -- I would say <return> is actually easier to grasp than a single-char . (But it's conceivable that pter will need this kind of translation in the future, for some other keys. Then the translations would need to consistently apply to all UI parts.)

So I guess I would simply eliminate SPECIAL = {} for now.

andrei-a-papou commented 6 months ago

Since you've added help.py, here's a new patch set against https://codeberg.org/vonshednob/pter/commit/0f1a4bcfd045f0123be2604d75e4714a396740a9:

20-new-strings-1.diff.gz 20-new-strings-2.diff.gz

vonshednob commented 5 months ago

These are all in place, too.

I cleared almost all SPECIAL translations except for " ": "<space>". That seemed necessary still.