search

voodoocode / pannengeraet-krank-knarrenbauer

🍳 Replaces Abhörgerät Kommt-Kampfhubschrauber by silly names
MIT License
67 stars 7 forks source link

Mutilates JavaDoc #23

Open TobiX opened 3 years ago

TobiX commented 3 years ago

The recent extension to multiple persons introduced a nasty bug in https://github.com/voodoocode/pannengeraet-krank-knarrenbauer/blob/077493d260713d9412f23e7de05d4d144062ee95/content.js#L220

When regexAbbrev is null, it isn't ignored, but cast to string, so any occurrence of null in a document is replaced by the first person where this is the case. While I found reading

Returns the login of the user making this request, if the user has been authenticated, or Olaf Scholz if the user has not been authenticated.

quite entertaining, I feel this wasn't intended behaviour.

voodoocode commented 3 years ago

Hilarious and great find. Will look into it, probably simply needs a check if a theres really a regex in there.

TobiX commented 2 years ago

It seems this bug is back in 0.4.2... (Best example: This bug report here :D)