ConcurrentModificationException thrown when using Wiser

[GoogleCodeExporter]

The Wiser class does not correctly synchronize access to its messages property, 
resulting in ConcurrentModificationException.

This problem occurs in our automated multi-threaded acceptance tests which use 
Wiser. However this problem can be demonstrated in a single thread by adding 
this test to MessageContentTest. 

  public void testDoesNotThrowConcurrentModificationException() throws Exception
    {
        MimeMessage message = new MimeMessage(this.session);
        message.addRecipient(Message.RecipientType.TO, new InternetAddress("anyone@anywhere.com"));
        message.setFrom(new InternetAddress("someone@somewhereelse.com"));
        Transport.send(message);
        List<WiserMessage> messages = this.wiser.getMessages();
        Iterator<WiserMessage> iterator = messages.iterator();
        Transport.send(message);
        iterator.next();
        assertEquals(2, this.wiser.getMessages().size());
    }

The simplest fix would be to change the property declaration in Wiser.java to 
    List<WiserMessage> messages = new CopyOnWriteArrayList<WiserMessage>();

Original issue reported on code.google.com by s_etheri...@hotmail.com on 19 Dec 2010 at 10:26

[GoogleCodeExporter]

see also issue 38

Original comment by s_etheri...@hotmail.com on 19 Dec 2010 at 10:35

• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Original comment by lhori...@gmail.com on 24 Dec 2010 at 9:21

• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Wiser.messages has been changed to 'protected' so that you can extend Wiser and 
change the implementation to anything you wish.

Original comment by lhori...@gmail.com on 24 Dec 2010 at 9:29

• Changed state: Fixed
• Added labels: ****
• Removed labels: ****