search

voodoodyne / subethasmtp

SubEtha SMTP is a Java library for receiving SMTP mail
Other
343 stars 138 forks source link

OSGi support #54

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The subethasmtp jar can be made OSGi compliant by adding the relevant headers 
in the manifest.

See attached patch.

Original issue reported on code.google.com by rocketra...@gmail.com on 12 Oct 2012 at 5:41

Attachments:

GoogleCodeExporter commented 9 years ago 
The way you attached it the configuration section is redundant.

Original comment by robert.munteanu on 1 Feb 2013 at 11:58

GoogleCodeExporter commented 9 years ago 
True, I like to have the section there so it is available for future changes. 
But yes, it is redundant.

Original comment by rocketra...@gmail.com on 1 Feb 2013 at 2:25

GoogleCodeExporter commented 9 years ago 
We can add OSGi support, but the primary build tool for the project is Ant. If 
the Ant build does not add OSGi information, then the released tarballs will 
also not include it, which may create some confusion. The files in the Maven 
repository will be OSGi compatible however. I guess that is enough. Jeff, could 
you review this patch from a Maven viewpoint and apply it?

Original comment by hontvari@flyordie.com on 11 Mar 2013 at 11:27

GoogleCodeExporter commented 9 years ago 
I have such a deep backlog of work that there's no way I will be able to look 
at this for weeks. I'd say go ahead... and as much as I hate maven, just go 
with mavenizing the project completely.

Original comment by lhori...@gmail.com on 11 Mar 2013 at 11:46

GoogleCodeExporter commented 9 years ago 
Ant can be made to add the OSGi meta-data, but its a little more cumbersome 
than with Maven. And it requires a copy of bnd to be available somewhere, 
unlike Maven which just downloads what it needs when it needs it.

Maven is one of those things that I have a serious love-hate relationship with. 
Most of the time I love it, but every now and then I can't help but jump up and 
down yelling and screaming. I can't wait for a better-maven-than-maven to kick 
ass and take names -- so far none of the contenders like Gradle, Buildr have 
done so, and I don't think they will until they are able to completely and 
pretty much transparently leverage the Maven ecosystem.

But all that being said, I think the Java world has for the most part moved 
beyond ant for build files. So for whatever its worth (not much) I would agree 
with comment #4.

Original comment by rocketra...@gmail.com on 12 Mar 2013 at 12:08

GoogleCodeExporter commented 9 years ago

Original comment by hontvari@flyordie.com on 12 May 2013 at 12:51

laeubi commented 9 years ago

BND is no requirement to add OSGi Meta-Data (and in fact BND has ant task as well!).