search

voodootikigod / node-rolling-spider

A library for controlling a Parrot Rolling Spider drone via BLE.
Other
253 stars 112 forks source link

Error after landing swarm and solved (perhaps) #49

Closed shiva02 closed 9 years ago

shiva02 commented 9 years ago

Hi,

When i use swarm.js in eg directory an when i press "q" for landing and error appears "this.members = []" I change line 220 in swarm.js in lib directory : this.members = [] ---> changed to this.membership = []; And it works...

voodootikigod commented 9 years ago

Can you submit a pull request please?

shiva02 commented 9 years ago

Yes of course, but I do not know too Github, how do I do once he asks me to choose the branch?

voodootikigod commented 9 years ago

https://help.github.com/articles/creating-a-pull-request/

Use this is as a guide, ping if you need more help

On Wed, Jun 24, 2015 at 10:11 AM, shiva02 notifications@github.com wrote:

Yes of course, but I do not know too Github, how do I do once he asks me to choose the branch?

— Reply to this email directly or view it on GitHub https://github.com/voodootikigod/node-rolling-spider/issues/49#issuecomment-114880754 .

Resseguie commented 9 years ago

@shiva02 for a simple one line change like that, you can also go to the file directly on github (https://github.com/voodootikigod/node-rolling-spider/blob/master/lib/swarm.js), click the pencil icon near the top-right of the code, and make the change there. When you click "propose file change" when you're done, it creates a branch for you and initiates a PR (pull request) for you. I usually avoid that for large changes, but for simple ones like this, it can be a quick solution.

shiva02 commented 9 years ago

@Resseguie Great, I do this now, thanks Resseguie

Shiva02