search

voole / thumbnailator

Automatically exported from code.google.com/p/thumbnailator
Other
0 stars 0 forks source link

Build fails under Java 6 #54

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Clone the source hg clone https://code.google.com/p/thumbnailator/
2. $ ant
3. Fail!

What is the expected output? What do you see instead?
The project is successfully built.

you will see the error below
hiroshi@alexios:~/workspace/thumbnailator$ ant test
Buildfile: /home/hiroshi/workspace/thumbnailator/build.xml

test:
    [junit] Running net.coobird.thumbnailator.ThumbnailatorTest
    [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec

BUILD FAILED
/home/hiroshi/workspace/thumbnailator/build.xml:74: Test 
net.coobird.thumbnailator.ThumbnailatorTest failed

Total time: 0 seconds
hiroshi@alexios:~/workspace/thumbnailator$ 

What version of the product are you using? On what operating system? Which
version of Java (Sun/Oracle? OpenJDK?) ?

$ java -version
java version "1.6.0_27"
OpenJDK Runtime Environment (IcedTea6 1.12.6) (6b27-1.12.6-1ubuntu0.12.04.2)
OpenJDK 64-Bit Server VM (build 20.0-b12, mixed mode)
$

Please provide any additional information below.

It seems that the build is failing because the tests are failing.
But as long as Java 6 is the supported platform, the tests shouldn't fail, I 
think.

BTW: Let's go to mvn/github, soon.

Original issue reported on code.google.com by daku...@gmail.com on 28 Aug 2013 at 10:20

GoogleCodeExporter commented 8 years ago 
Thank you for filing this report.

The problem has been reproduced, and I expect a fix to be applied in the next 
release.

------

The problem is two-fold:

  1. build.xml was written to run from Eclipse, so the test class files are not compiled and not added to the classpath.
  2. There are test cases which only succeeds in Java 5.

Original comment by coobird...@gmail.com on 3 Sep 2013 at 7:49

GoogleCodeExporter commented 8 years ago 
> 1. build.xml was written to run from Eclipse, so the test class files are not 
compiled and not added to the classpath.

This issue has been addressed so that the ant build does not depend on files 
created by Eclipse.

Therefore, it is now possible to build directly from ant.

> 2. There are test cases which only succeeds in Java 5.

Existing test cases have been changed so that the tests will succeed in Java 5 
and up.
(This has been confirmed though running `ant test` on Java 5, 6 and 7.)

------

The above fixes will be rolled into the next release.

Original comment by coobird...@gmail.com on 6 Sep 2013 at 6:15

GoogleCodeExporter commented 8 years ago 
Thank you!

Original comment by daku...@gmail.com on 8 Sep 2013 at 12:52

GoogleCodeExporter commented 8 years ago 
This issue has been addressed in Thumbnailator 0.4.6.

Original comment by coobird...@gmail.com on 8 Sep 2013 at 5:19