search

voorkant / voorkant-core

https://voorkant.org/
MIT License
2 stars 3 forks source link

Remove need for LD_LIBRARY_PATH=build/subprojects/curl-8.0.1/build/lib/.libs/ #5

Closed cyclops1982 closed 8 months ago

cyclops1982 commented 11 months ago

We currently need to add LD_LIBRARY_PATH=build/subprojects/curl-8.0.1/build/lib/.libs/ to our client executables. We need to avoid that.

Habbie commented 11 months ago

If our target environment is some fully functional system (say, a Debian machine), we could statically link just curl (and the other deps we build, of course), and pull in curl's deps (there's a lot of them right now!) from the system.

For smaller targets (embedded systems running old OE or OpenWrt builds) we should be as static as possible, perhaps only counting on a certain glibc/musl-version being available.

For both cases, but especially for the latter case, making our curl build smaller probably makes sense. In fact, we use so few features, and WebSockets is actually such a simple protocol, we may ditch curl some day.

That all said, for now, perhaps we can at least do some RPATH (if that is what it's called) magic in the build, so a dev build works without LD_LIBRARY_PATH

Habbie commented 10 months ago

(there's a lot of them right now!)

39 seriously reduced this to just libc/libz/libm and openssl

Habbie commented 8 months ago

fixed in #60 !