search

voormedia / rails-erd

Generate Entity-Relationship Diagrams for Rails applications
http://voormedia.github.io/rails-erd/
MIT License
4k stars 367 forks source link

Polluting global scope with rake task helper method #372

Closed olegykz closed 2 years ago

olegykz commented 3 years ago

Defining method in rake task is a bad practice which leads to polluting of global scope.

We have a say method defined at https://github.com/voormedia/rails-erd/blob/master/lib/rails_erd/tasks.rake#L3 which would be available everywhere and may lead to mixing up with the say method of ActiveRecord migration.