search

voormedia / rails-erd

Generate Entity-Relationship Diagrams for Rails applications
http://voormedia.github.io/rails-erd/
MIT License
3.98k stars 363 forks source link

'concentrate' in RailsERD::Diagram::Graphviz::GRAPH_ATTRIBUTES is enabled by default #71

Open stoffie opened 10 years ago

stoffie commented 10 years ago

The concentrate option makes look like the graph more professional, but most of the times will produce human unreadable output. I bother why it's enabled by default. I don't know anything about graphviz and dot, but I've disabled the option and now everything is fine. Is there any reason I'm missing to keep it activated? I'll provide some pictures if required. Thank you for your time

bf4 commented 10 years ago

Please provide

stoffie commented 10 years ago

I'm using erd 1.1, the target application is https://github.com/ict4g/SAMo on the branch devel, here is the output. I can't provide the original files here because github only allows images (EDIT: I forgot erd also makes jpgs/png as output and not only pdf files, so i created pdf files and the converted it to pictures eheh). I've encountered the same problem with other rails application but disclosing part of their source would be partially a problem. I'm kind of confused since you didn't notice the problem already: it's easy to encounter it using erd with any non-trivial model

erd_without_concentrate1 erd_with_concentrate1

kerrizor commented 9 years ago

We can "easily" add configuration options now. @stoffie which of your two examples is which?

stoffie commented 9 years ago

You can see a rendering error on the second image, the line from the 'indicator' model to 'answer' starts as continuous and ends dotted

kerrizor commented 7 years ago

This ties in with #256 and #217