search

vorburger / opendaylight-bot

Eclipse Public License 1.0
0 stars 2 forks source link

[WIP] An initial structure for accessing jenkins #12

Closed prateekiiest closed 6 years ago

prateekiiest commented 6 years ago

issue #8

prateekiiest commented 6 years ago

Sorry for the late update. Had to search for proper docs to use jenkins-rest.

http://cdancy.github.io/jenkins-rest/docs/javadoc/com/cdancy/jenkins/rest/features/JobsApi.html#buildWithParameters-java.lang.String-java.lang.String-java.util.Map-

is the way we can work around this.

vorburger commented 6 years ago

@prateekiiest would it be OK with you and seem fair if I only looked at this again when the red above is gone and it passes the build?

prateekiiest commented 6 years ago

sure no problem with that

prateekiiest commented 6 years ago

@vorburger Travis fails due to trailing whitespace. I have been trying to fix that since yesterday :P But can't find if there's any whitespace.

While I fix that , let me know how you would want to pass the job name and the password.

vorburger commented 6 years ago

Travis fails due to trailing whitespace. I have been trying to fix that since yesterday :P But can't find if there's any whitespace.

it clearly says where here:

[INFO] There are 3 errors reported by Checkstyle 8.4 with odl_checks.xml ruleset.
[ERROR] src/main/java/org/opendaylight/bot/jenkins/Client.java:[20] (regexp) RegexpSingleline: Line has trailing spaces.
[ERROR] src/main/java/org/opendaylight/bot/jenkins/Client.java:[23] (regexp) RegexpSingleline: Line has trailing spaces.
[ERROR] src/main/java/org/opendaylight/bot/jenkins/Client.java:[31] (regexp) RegexpSingleline: Line has trailing spaces.

in each of these lines, you simply have empty lines which are not just LF but space-space-space-LF.

While I fix that , let me know how you would want to pass the job name and the password.

how you would want to pass the job name and the password.

as per this earlier comment, add the job name and the password to bot/src/main/java/org/opendaylight/bot/BotConfiguration.java and pass it through to here

vorburger commented 6 years ago

@prateekiiest I just wanted to make sure that you had understood that you do not have to push all of these individual mini micro commits re. Checkstyle and wait for Travis builds - what everyone really does it just try it out locally, first simply by running ./mvnw clean package. That's much easier and gives a faster turn around. Just thought that you may not be aware of this.

prateekiiest commented 6 years ago

Oh!, my bad. I didn't know about it that we can do it locally too :smile: Thanks again.

vorburger commented 6 years ago

@prateekiiest I'm guessing you'll close/abandon this, based on #21 ?

prateekiiest commented 6 years ago

I guess I can work on this by updating the branch with the new code. Or should I open a fresh PR?

prateekiiest commented 6 years ago

I am closing this. I am opening a new PR for this