search

vorburger / opendaylight-bot

Eclipse Public License 1.0
0 stars 2 forks source link

[WIP] Add Jira Client #25

Closed ivange94 closed 4 years ago

ivange94 commented 6 years ago

This is a work in progress PR. The build is still failing due to some checkstyle issues.

@vorburger I tried finding this file odl_checks.xml but couldn't. Seems the checkstyle rules are defined here. I'd to import this file in my IDEA so that it does the code formatting for me and i won't have to reformat every time I build.

ivange94 commented 6 years ago

@vorburger not sure what this error means

: Compilation failure [ERROR] /Users/larry/workspace/opendaylight-bot/bot/src/main/java/org/opendaylight/bot/jira/Jira.java:[58,22] [FutureReturnValueIgnored] Return value of methods returning Future must be checked. Ignoring returned Futures suppresses exceptions thrown from the code that completes the Future.

ivange94 commented 6 years ago

Figured it out. I had to add a .claim() at the end of my chained method calls. I didn't know the methods won't be called until a terminating method is called.