search

vorburger / www.fineract.dev

https://www.fineract.dev
Apache License 2.0
16 stars 1 forks source link

Version numbering on demo.fineract.dev #13

Open ptuomola opened 2 years ago

ptuomola commented 2 years ago

Looks like the automatic version number generation is not working for demo.fineract.dev - the actuator etc just show the version number as 0.0.0:

"build": { "version": "0.0.0-ab6323e4", "user": { "name": "", "email": "" }, "host": "8c1bfa102e0e" },

I think this is probably because the build script in Google Cloud Build does a "git clone --no-tags" and the automatic versioning relies on tags to determine the version number. Perhaps it would be possible to clone the tags as well and see if this works?

vorburger commented 2 years ago

Indeed I do:

[ 'clone', '--verbose', '--progress', '--depth', '1', '--no-tags', '--branch', 'develop', 'https://github.com/apache/fineract.git', 'fineract.git' ]

I've removed that --no-tags just now. @ptuomola will you check if when you merge new PRs and it next redeploys it's better? If yes, ACK and close this issue.

If not, please re-assign to me. I guess if it still doesn't work (without --no-tags) then I should also remove --depth 1? That would be a shame (slower), but can do. Or perhaps --depth 2??

ptuomola commented 2 years ago

Unfortunately that still does not work... based on what I was able to quickly check, git describe does not work on shallow clones - so you'll probably need to remove --depth altogether to get this to work.

ptuomola commented 2 years ago

@vorburger I don't have the permissions to assign to you, but I've unassigned myself for now

vorburger commented 2 years ago

so you'll probably need to remove --depth altogether to get this to work.

Oh OK, then I've just entirely removed --depth 1 as well.

We'll see if that fixes that "version":"0.0.0- on https://demo.fineract.dev/fineract-provider/actuator/info on the next deploy.

vorburger commented 2 years ago

https://demo.fineract.dev/fineract-provider/actuator/info currently still has a "version": "0.0.0-34d11adb".

15 should be fixed first.