search

voreen-project / voreen

Voreen - The Volume Rendering Engine
Other
2 stars 2 forks source link

GeometryRenderer doesn't recompile shader when saving ShaderProperty #2

Open sleistikow opened 2 weeks ago

sleistikow commented 2 weeks ago

Using the rendering-geometry workspace, by opening the opaque ShaderProperty and changing any of the shader stages (e.g. by returning red fragments from the fragment shader stage outputFragment(vec4(1,0,0,1));) then saving the shader by pressing the save button with the disk icon doesn't trigger a recompilation of the shader.

The expected result would be that the shader is recompiled each time the user presses the save button in the ShaderProperty window.

sleistikow commented 2 weeks ago

It seems as if the auto-recompilation on save is only implemented for some processors such as SingleVolumeRayCaster but not for GeometryRenderer, GeometryProcessor and possibly others. The invalidation of the respective shader properties is to be handled by the processors themselves and some of them just don't handle it. I've enabled it for GeometryRenderer but for all processors where the feature is missing pressing F5 is still required.