search

voronianski / flux-comparison

:pencil: Practical comparison of different Flux solutions
https://labs.voronianski.dev/flux-comparison/
2.79k stars 214 forks source link

Add lux.js example #28

Closed ifandelse closed 9 years ago

ifandelse commented 9 years ago

@voronianski Thank you so much for creating this project! I've added an example implementation using lux.js. Please let me know if you need me to change anything, or if you have any questions. Thanks!

voronianski commented 9 years ago

@ifandelse thanks a lot for this PR!

Could you please fix the style issues and rebase with master in order to be merged like charm :)

ifandelse commented 9 years ago

@voronianski apologies - we have some aggressive esformatter settings which I completely forgot to disable. Happy to update and rebase. Traveling today, so it may be this afternoon before I can finish.

ifandelse commented 9 years ago

@voronianski OK - I rebased - please let me know if you need anything else changed. Thanks! :smile:

voronianski commented 9 years ago

@ifandelse everything's fine, just add lux/build/*.js to .gitignore please (https://github.com/voronianski/flux-comparison/blob/master/.gitignore#L12). Thanks! :smiley:

ifandelse commented 9 years ago

@voronianski no problem - just updated the PR, thanks!

voronianski commented 9 years ago

@ifandelse :+1: merged

ifandelse commented 8 years ago

@voronianski The lux.js example doesn't work because of this line being removed recently. I'm sure it was just a simple mistake, no worries. I will PR here shortly and add it back in.