search

voronianski / flux-comparison

:pencil: Practical comparison of different Flux solutions
https://labs.voronianski.dev/flux-comparison/
2.79k stars 214 forks source link

Shared package.json does not reflect individual dependencies #62

Closed gaearon closed 9 years ago

gaearon commented 9 years ago

Currently each project has its own package.json, but really all dependencies are in the top-level package.json. Is this by design? Do you plan to change this?

voronianski commented 9 years ago

@gaearon this project started as comparison of 3 frameworks so shared package.json worked well at that point, but as for now I think it will be smarter to move dependencies inside folders' package.jsons.

gaearon commented 9 years ago

Do you want to do this all at once, or are you fine with updating them one by one? I can send a PR for Redux deps.

voronianski commented 9 years ago

@gaearon let's try one by one, thanks!

gaearon commented 9 years ago

63

voronianski commented 9 years ago

https://github.com/voronianski/flux-comparison/commit/a62a97ae84634ca4e7c2677fa07e4cf9dc53125f

voronianski commented 9 years ago

I've left react in root folder's package.json (as well as some libs that are used almost everywhere e.g. object-assign, es5-shim, etc.) because components from ./common folder also need React in them.

As for me this looks fine, except that some libraries like Reflux or Fluxible have react as peerDependency and npm installs it inside of the solution folder.

/cc @gaearon

gaearon commented 9 years ago

Awesome! Yes, shared react is sensible.