voronianski / react-star-rating-component

Basic React component for star (or any other icon based) rating elements
http://voronianski.github.io/react-star-rating-component/example
MIT License
380 stars 77 forks source link

Rating is not accessible via tab #51

Open Theartbug opened 6 years ago

Theartbug commented 6 years ago

Cannot use keyboard tab to access each individual rating input.

Current behavior: pressing tab skips over the entire component.

Desired behavior: tab would jump into the first rating and tab across them, selecting them when enter is pressed.

nickLeidman commented 5 years ago

Looked into code, making it "tababble" isn't that hard. Though several other problems emerge. Apparently value change is bound to click and I can not see painless way to solve this issue without rewriting most of value handling mechanism.

// do not update internal state based on input value if prop passed if (value != null) { return; }