Convert label/inputs to spans when editing set to false

voronianski / react-star-rating-component

Basic React component for star (or any other icon based) rating elements

http://voronianski.github.io/react-star-rating-component/example

MIT License

380 stars 77 forks source link

Convert label/inputs to spans when editing set to false #59

Open mckeever02 opened 5 years ago

mckeever02 commented 5 years ago

Great library! I've just one suggestion.

When editing is set to false, wouldn't it be more appropriate and performant for the stars to be generated within <span>'s rather than as labels with hidden inputs?