search

voronianski / swipe-js-iso

Universal (a.k.a isomorphic) version of Swipe.js
https://www.npmjs.com/package/swipe-js-iso
MIT License
187 stars 57 forks source link

Fixes for widthOfSiblingSlidePreview #33

Open Cyberlane opened 5 years ago

Cyberlane commented 5 years ago

There was some rendering bugs when using widthOfSiblingSlidePreview, where the slide to the right was always the last slide instead of the next. This was simply due to the zIndex order, naturally the left worked fine.

This fixes #32 and #24

Cyberlane commented 5 years ago

@gauravAtProptiger aha, perfect! In which case I need to do the more complicated solution of physically moving the cards further away instead of simple z-index.

I will try to get a solution made later today.

gauravAtProptiger commented 5 years ago

@Cyberlane Any luck?

Cyberlane commented 5 years ago

@gauravAtProptiger sorry, I ended up having to fly abroad for business. I have a few hours now, so will try to solve this now.

Cyberlane commented 5 years ago

@gauravAtProptiger I have found a way to make this work very smoothly with very minimal code, however I need to find out from @voronianski the official list of supported browsers first. The simple fix I have in mind does not work on Opera - making it work through many older browsers will be a bit more effort (but I can achieve it), I just want to confirm how much effort needs to be put into this first.

Cyberlane commented 5 years ago

I believe I have a working solution now @gauravAtProptiger - feel free to give this a try.

maxchernin commented 4 years ago

hi guys, is this expected to be solved soon? :( having this bug in a go-to-live app

robsoncoelho commented 4 years ago

Any news about this PR @Cyberlane and @gauravAtProptiger ?