search

voronianski / swipe-js-iso

Universal (a.k.a isomorphic) version of Swipe.js
https://www.npmjs.com/package/swipe-js-iso
MIT License
187 stars 57 forks source link

Prevent vertical scroll in Safari 10 iOS 10 #7

Closed bu1ka closed 7 years ago

bu1ka commented 7 years ago

In iOS 10 webkit has introduced a new touch event called touchforcechange. Somehow if you don't have a listener on this event, in touchmove the listener will receive the wrong touches.pageY coords and this check will fail and while you are dragging a slide vertical scroll will occur.

NOTE: I have tried to replace the second argument function() {} for this call element.addEventListener('touchforcechange', function() {}, false); with noop from this but it doesn't work.

So, it would be great if you merged my pr as soon as possible! And update react-swipe deps.

Thanks.

doochik commented 7 years ago

@voronianski you've merged PR. Could you please release new version to npm?

bu1ka commented 7 years ago

@voronianski Please release new version to npm and update react-swipe dependency with this version of swipe-js-iso.

mckinnsb commented 7 years ago

@voronianski I basically had to fork react-swipe because swipe-js-iso has not had a new version released. Please release a new version to NPM.

PythonicNinja commented 7 years ago

@voronianski Please release new version 🙇

voronianski commented 7 years ago

@PythonicNinja it's released already - 2.0.4.