search

voronkovich / gitignore.plugin.zsh

ZSH plugin for creating .gitignore files.
MIT License
53 stars 5 forks source link

on macOS \L in sed expression doesn't work #8

Closed ajanian closed 4 years ago

ajanian commented 4 years ago

The version of sed that ships with macOS doesn't work well with the \L expression. All the available choices in the template list are prepended with L. This is a gnu sed extension. I think the solution is to have an environment variable that points to the sed location. I'm happy to provide a PR if you would like. In my case I did brew install gnu-sed and then I use that version of sed which is gsed

ajanian commented 4 years ago

As a short term fix you can edit the zsh script gitignore.plugin.zsh to remove the \L from the sed expression on line 54 OR you can install gsed and leave the \L and change the sed command to be gsed

voronkovich commented 4 years ago

@ajanian, Thank you for investigation of this problem! I would appreciate the PR. I think we could try to use tr utility to lowercase templates names.

ajanian commented 4 years ago

done.  great idea on tr.  PR submitted

On Sun, Apr 19, 2020 at 1:58 PM, Oleg Voronkovich < notifications@github.com > wrote:

@ ajanian ( https://github.com/ajanian ) , Thank you for investigation of this problem! I would appreciate the PR. I think we could try to use tr utility to lowercase templates names.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/voronkovich/gitignore.plugin.zsh/issues/8#issuecomment-616196148 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAAYLBBHZHIIGEJ4KBCJRWDRNM3VFANCNFSM4ML3SBEA ).