search

vorot / roots

Library of well known algorithms for numerical root finding.
BSD 2-Clause "Simplified" License
50 stars 18 forks source link

roots::numerical::SearchError is private #10

Closed JP-Ellis closed 3 years ago

JP-Ellis commented 3 years ago

The numerical algorithms return SearchError as part of the Result; however the crate does not expose SearchError. As a result, I can call the numerical algorithm functions, but if I wish to pass the result to another function, I cannot actually implement a function with the return type Result<f64, SearchError>.

Let me know if you would like a PR.

vorot commented 3 years ago

The numerical algorithms return SearchError as part of the Result; however the crate does not expose SearchError. As a result, I can call the numerical algorithm functions, but if I wish to pass the result to another function, I cannot actually implement a function with the return type Result<f64, SearchError>.

Let me know if you would like a PR.

Hi, thank you for using this library. A PR that exposes SearchError is welcome, as well as the one with extending the info provided by it. Please include at least one test case for each extension.

vorot commented 3 years ago

One-line change

blagovestb2c2 commented 3 years ago

Hey, it seems that the latest available 0.0.6 version still has SearchError private. Could we perhaps get a new release that makes this change officially available

vorot commented 3 years ago

v0.0.7 is published

пн, 14 июн. 2021 г. в 13:58, blagovestb2c2 @.***>:

Hey, it seems that the latest available 0.0.6 version still has SearchError private. Could we perhaps get a new release that makes this change officially available

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/vorot/roots/issues/10#issuecomment-860627120, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACX6MBPCEX4HITIGTEFXOBTTSXVH5ANCNFSM4WMHNS7A .