vors / ZLocation

ZLocation is the new Jump-Location
MIT License
567 stars 29 forks source link

Duplicate Unc Paths in Database Where Only One Is Updated #127

Open mattcargile opened 2 years ago

mattcargile commented 2 years ago

Line below returns a path like \\server\path\to\file while the prompt function uses $pwd which returns Microsoft.PowerShell.Core\FileSystem::\\server\path\to\file

https://github.com/vors/ZLocation/blob/d569d35db3d05d9b4d96d00bbc0ec0dbd105d844/ZLocation/ZLocation.psm1#L248

Not sure how to handle. One one hand the below code could Resolve-Path or maybe append depending on powershell or pwsh environment. On the other, I worry about the Add-ZWeight overwriting previous weights with 0.

https://github.com/vors/ZLocation/blob/d569d35db3d05d9b4d96d00bbc0ec0dbd105d844/ZLocation/ZLocation.psm1#L266-L270

P.S. Love the module alot. Would love to see these two pull requests discussed and pushed into a release.

https://github.com/vors/ZLocation/pull/121 https://github.com/vors/ZLocation/pull/109