Create the powershell proxy during execute in order to better handle exceptions.

vors / jupyter-powershell

PowerShell language kernel for Jupyter

MIT License

132 stars 26 forks source link

Create the powershell proxy during execute in order to better handle exceptions. #27

Closed corivera closed 4 years ago

corivera commented 4 years ago

Fixes https://github.com/vors/jupyter-powershell/issues/11

Currently the kernel hangs if powershell isn't installed, since an exception is being thrown during init. My solution to this is to move the proxy creation to do_execute so that we can return a well-formatted message.

A nice side-effect of putting this check in do_execute is that if powershell isn't found, then the user can install it and run the cell again successfully without having to restart the kernel/notebook.

vors commented 4 years ago

@chlafreniere removed myself as a reviewer, please feel free to drive this as you see appropriate!

chlafreniere commented 4 years ago

Will do. Thanks!