search

vors / jupyter-powershell

PowerShell language kernel for Jupyter
MIT License
132 stars 26 forks source link

Interactive Streaming Output Support #39

Closed VasuBhog closed 3 years ago

VasuBhog commented 3 years ago

This PR introduces interactive streaming support by making changes to how we call the run command in the proxy. Iterating over the run command allows us to send information to the cell's output iteratively.

PowerShell_streaming

VasuBhog commented 3 years ago

@chlafreniere, @pensivebrian, and @corivera please review the PR. Looks like I am unable to assign individuals due to permissions. Let me know if you have any questions!

pensivebrian commented 3 years ago

Anyway to add tests for this? In particular, really large strings to make sure we handle cases where a string being output by powershell over stdout is split over two messages.

VasuBhog commented 3 years ago

Addressed another issue when re-running a large string (over 10mb) after initial execution (2nd or 3rd time). Changing the write function to look for the ^ in a more efficient way. Added test using the jupyter kernel test tool for this specific scenario, did plenty of manual testing as well (large strings, and ^ within a string for example).

VasuBhog commented 3 years ago

This PR fixes #37