search

vortex-5 / ddwrt-bwmon

An Individual Bandwidth Monitor For DD-WRT
171 stars 37 forks source link

Making Dark Theme Default #50

Closed target123 closed 6 years ago

target123 commented 7 years ago

Hi,

Would it be possible to make Dark Theme the default one without having to manually pressing the dark theme button every time we access the page?

Thanks in advance,

vortex-5 commented 7 years ago

If you enable cookies it remembers your choice unless you browse this in incognito all the time it shouldn't be an issue.

target123 commented 7 years ago

Would it not be possible to be set as default system wide?

vortex-5 commented 7 years ago

For security reasons the web page cannot write anything to the router by design. If you want this you can modify the J's file to default to the dark theme.

target123 commented 7 years ago

Would you mind showing how?

Thanks!

Btw! it would be nice to provide an option during installation to ask whether dark or light theme should be the default one! :)

vortex-5 commented 7 years ago

I didn't write the dark theme feature this would be better directed at the original author.

I'm out of the country and do not have access to a computer in the mean time.

J3n50m4t commented 7 years ago

In my fork I created a branch dark_default. You can check it out here. It has only been little changes. https://github.com/J3n50m4t/ddwrt-bwmon/commit/36f5234c70d9ac1ee81b26a8a6fa2c8dc1aa4896 Edit: I guess it's clear you just have to replace the changed files.

Btw! it would be nice to provide an option during installation to ask whether dark or light theme should be the default one! :)

I like the idea but we would have to add this question for every option. May someone prefers compact over normal (me) or another example: Kbps & KB/s. If I find a smart way to change codelines without duplicating everything I will may create a PR.

But for now you also could just switch it out. It works for every other option the same way:

vortex-5 commented 6 years ago

You know I like the dark theme more too recently I think I may take your commit up on that and make the dark theme default.

(And wait for any complaints lol)

expect an updated version soon.

vortex-5 commented 6 years ago

After a long wait the dark theme is now default and the front page has been updated with a new screenshot to reflect his.