vortex-exoplanet / VIP

VIP is a python package/library for angular, reference star and spectral differential imaging for exoplanet/disk detection through high-contrast imaging.

http://vip.readthedocs.io/

MIT License

70 stars 57 forks source link

possible update: in negfc/utils_negfc #355

Closed KristinaDavis closed 5 years ago

KristinaDavis commented 5 years ago

import statement fails: from matplotlib.pyplot import plot, xlim, ylim, hold, axes, gca, show (later in code, line 108) if display:

hold(True)

    plot(u,v,'ks',x,y,'r')

'hold' is depreciated in pyplot > 2.0, see https://matplotlib.org/api/_as_gen/matplotlib.pyplot.hold.html

I am currently using matplotlib=3.0.2. I can just delete those lines from my code, which I think will revert to the default of automatically holding unless you clear the axis (as per the documentation). However, it might be worth considering updating for those using later packages of matplotlib.

Thanks!

carlos-gg commented 5 years ago

Unfortunately, VIP is still using matplotlib ~= 2.2 (see requirements.txt), and the import statement you mention seems to work fine in this case. Of course, it'd be great to make VIP compatible with matplotlib > 3.0. That will require checking all functions that import from matplotlib to see if there are fixes to be applied. Would you like to contribute, we definitively welcome PRs! :)

carlos-gg commented 5 years ago

I hope you managed to install VIP. I wanted to let you know, before closing this issue, that VIP now works with matplotlib 3. Cheers

KristinaDavis commented 5 years ago

Thanks!

Kristina K. Davis, PhD. Astronomy & Astrophysics Postdoctoral Fellow National Science Foundation University of California, Santa Barbara k_davis@physics.ucsb.edu kristinadavis.weebly.com

On Thu, Mar 28, 2019 at 6:36 AM Carlos Alberto Gomez Gonzalez < notifications@github.com> wrote:

Closed #355 https://github.com/vortex-exoplanet/VIP/issues/355.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vortex-exoplanet/VIP/issues/355#event-2236284233, or mute the thread https://github.com/notifications/unsubscribe-auth/AIfntQ1ONf4trxmNAydNLwGAiknZEJEpks5vbMVSgaJpZM4abWm6 .