Closed IainHammond closed 1 year ago
Merging #612 (fdcb1a6) into master (f046ff0) will increase coverage by
1.53%
. Report is 7 commits behind head on master. The diff coverage is51.56%
.:exclamation: Current head fdcb1a6 differs from pull request most recent head 7b676cd. Consider uploading reports for the commit 7b676cd to get more accurate results
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## master #612 +/- ##
==========================================
+ Coverage 56.02% 57.55% +1.53%
==========================================
Files 67 67
Lines 13446 13461 +15
==========================================
+ Hits 7533 7747 +214
+ Misses 5913 5714 -199
Files Changed | Coverage Δ | |
---|---|---|
vip_hci/fm/negfc_fmerit.py | 79.25% <ø> (ø) |
|
vip_hci/fm/negfc_mcmc.py | 70.21% <ø> (-0.16%) |
:arrow_down: |
vip_hci/fm/negfc_nested.py | 58.06% <ø> (ø) |
|
vip_hci/fm/negfc_simplex.py | 86.61% <ø> (ø) |
|
vip_hci/objects/dataset.py | 43.84% <0.00%> (ø) |
|
vip_hci/objects/postproc.py | 63.16% <0.00%> (+34.93%) |
:arrow_up: |
vip_hci/psfsub/framediff.py | 29.85% <ø> (ø) |
|
vip_hci/psfsub/llsg.py | 20.09% <ø> (ø) |
|
vip_hci/psfsub/loci.py | 76.33% <ø> (ø) |
|
vip_hci/psfsub/medsub.py | 77.10% <ø> (ø) |
|
... and 13 more |
... and 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
hello there's a new function in
vip_hci.fits
for only opening FITS headers (open_header
). This is designed to be super lightweight and is a wrapper around a core astropy function with a nice VIP interface. It behaves very similar toopen_fits
but is about 40 times faster to use on an average sized SPHERE data set, depending on your disk speed and file sizes. Good for pipeline use. It allows for opening HDU headers by numbern
or by HDU nameextname
too.I adapted the new try/except in
open_fits
to better catch the specific astropy error it's meant to avoid, rather than potentially hiding something else. This came about because I noticed this try/except doesn't work on SPHERE data that has BZERO/BSCALE/BLANK header keywords as it still opens the file and raises the error later when accessing the hdulist.data containing those keywords. I don't know any way to avoid this and it's uncommon enough to probably not matter. I've also tidied the code and improved the verbosity.Every typo of FWHM has been fixed and bad pixel correction no longer reminds you that ADACS made it lighting fast even if you ask for verbose=False, but we very much appreciate their work and I've added our developer to the authors of that function.
Finally I fixed an upcoming
scipy.ndimage.filter
deprecation