Closed IainHammond closed 10 months ago
Merging #622 (fefd9cd) into master (12e61f3) will increase coverage by
1.57%
. The diff coverage is76.09%
.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@ Coverage Diff @@
## master #622 +/- ##
==========================================
+ Coverage 55.80% 57.37% +1.57%
==========================================
Files 67 67
Lines 13549 13541 -8
==========================================
+ Hits 7560 7768 +208
+ Misses 5989 5773 -216
Files | Coverage Δ | |
---|---|---|
vip_hci/fits/fits.py | 45.57% <ø> (ø) |
|
vip_hci/fits/headers.py | 35.71% <ø> (ø) |
|
vip_hci/metrics/detection.py | 63.56% <100.00%> (-0.32%) |
:arrow_down: |
vip_hci/metrics/roc.py | 9.01% <100.00%> (ø) |
|
vip_hci/preproc/parangles.py | 23.88% <ø> (ø) |
|
vip_hci/var/shapes.py | 70.00% <100.00%> (-0.11%) |
:arrow_down: |
vip_hci/metrics/completeness.py | 73.09% <88.89%> (ø) |
|
vip_hci/stats/distances.py | 28.95% <85.71%> (-0.11%) |
:arrow_down: |
vip_hci/preproc/recentering.py | 66.33% <60.87%> (-0.10%) |
:arrow_down: |
... and 9 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Thanks @IainHammond !
normalization
being added tophase_cross_correlation
, being set to true by default, which changed the resulting shifts. We now providenormalization=None
to retain the original behaviour. _shift_dft also catches the case where the latest version ofphase_cross_correlation
(0.22) from scikit-image returns all three variables always rather than just the shifts (which the VIP code was originally designed around), and keeps the original behaviour of the _shift_dft function. The code is now compatible with versions 0.19-> of scikit-image , however I recommend 0.22 (latest release) due to the performance improvements