search

vortex-exoplanet / VIP

VIP is a python package/library for angular, reference star and spectral differential imaging for exoplanet/disk detection through high-contrast imaging.
http://vip.readthedocs.io/
MIT License
70 stars 57 forks source link

Made the contrast_curve function more robust to classes with inherited attributes #626

Closed JustLatour closed 9 months ago

JustLatour commented 9 months ago

In the contrast curve function, an algorithm using a class with certain specific inherited attributes is not supported. This change makes it more robust to those kinds of algorithms if they need to be used.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6028e7e) 55.94% compared to head (20da21c) 22.31%.

Files Patch % Lines
vip_hci/metrics/contrcurve.py 0.00% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #626 +/- ## =========================================== - Coverage 55.94% 22.31% -33.63% =========================================== Files 67 67 Lines 13535 13535 =========================================== - Hits 7572 3020 -4552 - Misses 5963 10515 +4552 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.