search

vortexntnu / perception-auv

The workspace for the Perception team!
MIT License
1 stars 0 forks source link

transferred over old repo #6

Closed jorgenfj closed 1 month ago

jorgenfj commented 1 month ago

Not a fan of the use of " instead of ' in launch files. The convention for launch files appears to be '. Is it possible to make the formatter detect launch files to account for this?

Senja20 commented 1 month ago

Not a fan of the use of " instead of ' in launch files. The convention for launch files appears to be '. Is it possible to make the formatter detect launch files to account for this?

I have remote automatic formatting and left just a Python black checker. I also pass --skip-string-normalization as an argument, so it should not react to the quotes—temporary solution. I do not want to use non-black formatted on a single repo when we use the black formatter everywhere else. If black is an issue, maybe we should organize a migration to another formatter across the organization(?)

kluge7 commented 1 month ago

Not a fan of the use of " instead of ' in launch files. The convention for launch files appears to be '. Is it possible to make the formatter detect launch files to account for this?

I have remote automatic formatting and left just a Python black checker. I also pass --skip-string-normalization as an argument, so it should not react to the quotes—temporary solution. I do not want to use non-black formatted on a single repo when we use the black formatter everywhere else. If black is an issue, maybe we should organize a migration to another formatter across the organization(?)

@Senja20 I know that The Ruff Formatter could be an alternative to look into!