search

vortexntnu / rov-control

Complete control system for Vortex' ROV
13 stars 9 forks source link

Add support for valve stepper #67

Closed aksell closed 6 years ago

aksell commented 6 years ago

Add valve stepper control and do some pep8 formatting of python scripts. I am not sure using the d-pad on the xbox controller is the best solution to control the valve stepper. Any thoughts on this?

aksell commented 6 years ago

The vertical d-pad might be nice to use for tilting the front camera. Should probably not use it for the valve stepper.

mortenfyhn commented 6 years ago

Regarding which button to use: Just let people try to sail the rov using different button options and pick the one they like, and merge this without worrying about the button choice now.

aksell commented 6 years ago

The nn must have been a typo, I removed it. It has been tested on hardware. Thanks.

aksell commented 6 years ago

Huh, i dont know. I guess the handles we are going to turn with the downwards facing stepper just feelt like a valve. Would vertical_stepper maybe be better?