vortexntnu / vortex-auv

Software for guidance, navigation and control for the Vortex AUVs. Purpose built for competing in AUV/ROV competitions.
https://www.vortexntnu.no/
MIT License
91 stars 21 forks source link

Joystick guidance node #145

Closed jae-hyeong-hwang closed 3 years ago

jae-hyeong-hwang commented 3 years ago

Joystick node needs to be published to setpoints for the reference model.

that modes need to be bounded for control buttons.

Edit: The joystick driver where the buttons are bound etc should be kept separate from node/code that implements the ROS specifics, which in turn should be kept separate from the "math" part of the joystick.

chrstrom commented 3 years ago

Make sure to keep integral action always off for the dp controller

chrstrom commented 3 years ago

Here is the proposed structure for solving this issue.

Structure

chrstrom commented 3 years ago

Pull #152 implements the structural changes to the joystick system, minus the control mode select. (This will come when the joystick is to be integrated with the controller

oyssolbo commented 3 years ago

Should have that we can use the "start" on joystick to switch between ROV and AUV-state or something

jae-hyeong-hwang commented 3 years ago

Should have that we can use the "start" on joystick to switch between ROV and AUV-state or something

remember this talk with you on sunday. In other words, "start" to make on and off the control by joystick?

oyssolbo commented 3 years ago

Start in AUV-mode by default, but possible to switch to ROV-mode via the joystick. I have written some code, but not published as of yet

chrstrom commented 3 years ago

Start in AUV-mode by default, but possible to switch to ROV-mode via the joystick. I have written some code, but not published as of yet

Especially for Tau, I think having the ability to intervene at any point is good. We might have to add something in the current state machine that exists whatever it is currently doing when the joystick is activated? For the potential robosub stuff, we won't have a tether/joystick connected, so it seems safe to have it this way 👍

chrstrom commented 3 years ago

Closing this now that #162 has been merged