talisto
commented
3 years ago I'm stuck on this too, this library is the last remaining blocker I have in migrating a large application to PHP 8.
It appears that every call to this logger sends an object as the first parameter, so it seems like the easiest solution would be to simply make the $object parameter a required parameter, like so:
public static function log($object, $level, $message, $context = [])
Every method in that class would need to be changed.
This is actually an issue with the client library, which is a separate repository. Someone has already submitted a pull request with a fix for the issue, but that repository hasn't been updated since 2018, so I think the chances of the fix getting merged in are pretty slim..
davidwdan
Hello,
to make the default example work, the Logger class at client/src/Logging/Logger.php needs to be adjusted to prevent errors like Required parameter $message follows optional parameter $object. I would suggest to either change the order or provide default parameters. e.g.
$message = ''and on Line 31 for example:public static function log($object = null, $level = LogLevel::INFO, $message = '', $context = [])But even better:
public static function log($message, $object = null, $level = LogLevel::INFO, $context = [])Right now it looks like this, which doesnt work with PHP 8:
public static function log($object = null, $level, $message, $context = [])