Closed kryo2k closed 8 years ago
https://github.com/voryx/angular-wamp/blob/master/src/angular-wamp.js#L399-L401
Suggesting to add:
return subscription;
Currently promise returns undefined. I worked around this with an extension of that method.
Patched:
subscribeOnScope: function (scope, channel, callback) { return this.subscribe(channel, callback).then(function (subscription) { scope.$on('$destroy', function () { return subscription.unsubscribe(); }); return subscription; }); },
@davidwdan Thanks! @kryo2k Tested and works. Can you verify?
Fixed https://github.com/voryx/angular-wamp/pull/51
https://github.com/voryx/angular-wamp/blob/master/src/angular-wamp.js#L399-L401
Suggesting to add:
Currently promise returns undefined. I worked around this with an extension of that method.
Patched: