search

voryx / thruway.js

RxJS WAMPv2 Client
MIT License
28 stars 13 forks source link

RxJs 6 / Angular 6 Compatibility #19

Open nwkyom opened 6 years ago

nwkyom commented 6 years ago

Hi, First of all, thank you for the nice job you've done with this library ! I was wondering if you're planning to release a version based on RxJs 6 (as Angular 6 just did) ?

BillyGeat commented 6 years ago

The good / great thing is, that after upgrading to Angular 6 and with use of rxjs-compat all works as before! Very happy about this! But of course, a pure rxjs 6 solution without the -compat would be also great...

davidwdan commented 6 years ago

When https://github.com/voryx/thruway.js/issues/15 is resolved, RxJS 6 will be supported.

BillyGeat commented 6 years ago

Any hint / idea how to update the Angular core?

>ng update @angular/core
Package "thruway.js" has an incompatible peer dependency to "rxjs" (requires "^5.4.0", 
would install "6.3.2").
Incompatible peer dependencies found. See above.
BillyGeat commented 6 years ago

I have "forced" the update to 6.3.2 of rxjs (ng update @angular/core --force) and then I got also rxjs-compat in the version 6.3.2. But there seams to be a problem with this compat-version as it does not handle some things correct. Solution was to go back to 6.2.2 for both (using this for example: https://github.com/ReactiveX/rxjs/issues/4070#issuecomment-419041214).

I hope, you will solve the https://github.com/voryx/thruway.js/issues/15 issue to get real v6 support without -compat soon...

chiefmc commented 5 years ago

Same here. Looking forward to support rxjs 6.x natively without rxjs-compat

andzejsw commented 5 years ago

Any progress on this one?

andzejsw commented 5 years ago

I have "forced" the update to 6.3.2 of rxjs (ng update @angular/core --force) and then I got also rxjs-compat in the version 6.3.2. But there seams to be a problem with this compat-version as it does not handle some things correct. Solution was to go back to 6.2.2 for both (using this for example: ReactiveX/rxjs#4070 (comment)).

I hope, you will solve the #15 issue to get real v6 support without -compat soon...

Works for me ok with versions: "rxjs": "^6.4.0", "rxjs-compat": "^6.4.0",

27leaves commented 5 years ago

I tried to setup a new project today with thruway.js@2.0.0-beta3, rxjs-compat@6.4.0 and rxjs@6.4.0 and I get an error 

  open.do(...).combineLatest is not a function
    at new Client (Client.js:134)

With rxjs@6.3.3 and rxjs-compat@6.3.3 there is another error

  Observable_1.Observable.of is not a function
    at new Client (Client.js:83)

Using Ionic4 with angular@7.2.2 btw

davidwdan commented 5 years ago

@creat-or that's an issue with 2.0.0-beta3. Can you try 2.0.0-beta4?

27leaves commented 5 years ago

@creat-or that's an issue with 2.0.0-beta3. Can you try 2.0.0-beta4?

It works! Thank you!! 👍 Didn't know that beta4 was available :)

davidwdan commented 5 years ago

I just published it.

If this works for rxjs6, I'll leave rxjs-compat as the suggested solution. We're not using rxjs6 anywhere at the moment, so I haven't been able to test it thoroughly.