vosmiic / jellyfin-ani-sync

Synchronize anime watch status between Jellyfin and anime tracking sites.
GNU General Public License v3.0
215 stars 15 forks source link

Shikimori provider resets score #107

Closed tie closed 4 months ago

tie commented 4 months ago

Describe the bug

Shikimori series score is reset on update.

Logs

[2024-02-29 11:40:39.973 +03:00] [INF] [10] jellyfin_ani_sync.UpdateProviderStatus: (Tvdb) Anime reference found in anime list XML
[2024-02-29 11:40:39.974 +03:00] [INF] [10] jellyfin_ani_sync.UpdateProviderStatus: Retrieving provider IDs from offline database...
[2024-02-29 11:40:40.450 +03:00] [INF] [10] jellyfin_ani_sync.UpdateProviderStatus: Retrieved provider IDs
[2024-02-29 11:40:40.451 +03:00] [INF] [10] jellyfin_ani_sync.UpdateProviderStatus: Using provider Shikimori...
[2024-02-29 11:40:51.409 +03:00] [INF] [11] jellyfin_ani_sync.UpdateProviderStatus: (Shikimori) Found matching series: Ishura
[2024-02-29 11:40:51.782 +03:00] [INF] [11] jellyfin_ani_sync.UpdateProviderStatus: (Shikimori) Series (Ishura) found on watching list
[2024-02-29 11:40:53.176 +03:00] [INF] [11] jellyfin_ani_sync.UpdateProviderStatus: (Shikimori) Updated series (Ishura) progress to 9

To Reproduce

Steps to reproduce the behavior:

  1. Set a score for a title on Watching list.
  2. Watch next episode in Jellyfin.

Expected behavior

Score does not change on series progress or status update.

Screenshots

image

Desktop:

vosmiic commented 4 months ago

Probably just a case of retrieving the score and including it in the update. Do you know of any other metadata that is wiped when updating?

tie commented 4 months ago

@vosmiic, IIRC it is possible to update title notes on Shikimori via text field (see https://shikimori.one/api/doc/2.0/user_rates/create), and the notes I’ve had on the anime from this issue are fine even though the score was reset.

I’m not familiar with C#, but I suspect that the score field is serialized to default zero value?

https://github.com/vosmiic/jellyfin-ani-sync/blob/de2c88303a6594af8f3acac4f059755e48171d08/Models/Shikimori/ShikimoriUpdate.cs#L23-L24