#30 Occurrence Details - Githubissues

vostpt / mobile-app

VOSTPT App for Android and iOS (supported by Flutter Portugal)

MIT License

25 stars 25 forks source link

#30 Occurrence Details #102

Closed CodeGlitch closed 4 years ago

CodeGlitch commented 4 years ago

Made some glue for the awesome widgets someone already had made for "Clicking on a marker shows the Occurrence Details". Also added the Flexible widget to some of the Text widgets, for smaller screens. Couldn't compile on Android without changing build.graddle to 3.3.1 from 3.2.1. I left the gradle change out to not break someone else work.

Vanethos commented 4 years ago

@CodeGlitch Please check that you have now conflicts in your file: lib/presentation/ui/home/home_page.dart

CodeGlitch commented 4 years ago

I didn't plan to, but i managed to do some extra work on the code (I will get back on studying tomorrow!). I never used bloc, so, be nice! x) Hoping this improved what was sent before, but I'm expecting some requested changes! Cheers! /offline

Vanethos commented 4 years ago

Also @CodeGlitch I will only be able to approve the PR after you solve the Conflcit Issues

Vanethos commented 4 years ago

I am having one issue @CodeGlitch:

Sometimes when I'm clicking on the same marker (does not happen with all markers) it will select a different occurrence and if I click again it will show another one.

see https://drive.google.com/open?id=1L1M0bWhBPR8wb69YQpWKRQ5S0XqYxSVi for video evidence

Also:

If you click outside the info widget (eg: over the map), is it possible to close the widget?
Since we'r already on the map, you don't need to show the map widget (@OldMetalmind we're on the same page on this one, correct?)
When the widget is open, you are not showing the occurrence type
Please change the icon colors to white

Vanethos commented 4 years ago

@CodeGlitch one small thing: if you fixed the issues that me and @miguelpruivo point out, please mark the issue as "solved", this way we'll know what is still missing! :D

CodeGlitch commented 4 years ago

I created a new breanch, updated, and submitted a new PR, #109. This one should be closed because its obsolete.