search

vostpt / mobile-app

VOSTPT App for Android and iOS (supported by Flutter Portugal)
MIT License
25 stars 25 forks source link

About Screen Implemented #77

Closed Thesmader closed 4 years ago

Thesmader commented 4 years ago

Fixes #18

About Screen has been implemented.

Result: vost-pt

Thesmader commented 4 years ago

@Vanethos, thank you for suggesting changes. I'll resolve them as soon as possible.

Vanethos commented 4 years ago

@Thesmader It seems that are some merge conflicts,

Can you see them before I check the PR please?

Thesmader commented 4 years ago

@Vanethos I have not pushed the latest commit, I'll resolve the conflicts and send it today

Vanethos commented 4 years ago

Everything seems great with the latest push, my only question is: where is the _launchURL, _launchEmail and _launchPhone used?

How can clicking in a contact that has an email info launch the email app?

Thesmader commented 4 years ago

Since the framework for attaching the phone numbers, URL or email to the contacts wasn't available; I haven't included the function calls in the onTap of the contactsBuilder widget. When there is a way to store the above information for each contact, the _launchURL() and other functions can be modified and the phone, email or URL can be passed as arguments and used to launch Phone app, Email app or open URL in a browser.

Vanethos commented 4 years ago

Thank you so much for your great PR @Thesmader 👍 It is a great addition to our project! :D