vostpt / mobile-app

VOSTPT App for Android and iOS (supported by Flutter Portugal)
MIT License
25 stars 25 forks source link

Feature: On Site Help Widget Implementation (#21) #86

Closed TomerPacific closed 4 years ago

TomerPacific commented 4 years ago

Adding the implementation for the on site help widget. This widget is a Stateless widget which receivers four parameters :

Per the description, the callback is redacted. For now, since the preferred assets are not available, the usage of the vost_logo_white asset was used.

This is why the background is black and the text color is white.

Resolves #21

Vanethos commented 4 years ago

@TomerPacific Just one thing after you see the comments, please check that there are now conflicts with the misc.dart file. If you can resolve them that'd be great!

TomerPacific commented 4 years ago

@Vanethos , I'm seeing the build fail on this: Getter not found: 'MAPBOX_URL_TEMPLATE' inside home_page.dart. This is a file I haven't edited, any idea why?

Vanethos commented 4 years ago

@TomerPacific Yes, give me 10 minutes, sorry about that!

Vanethos commented 4 years ago

@TomerPacific

Either follow these instructions:

/*
 * Map Widget
 *
 * In order to use the map widget, a `keys.dart` file must be created at the root
 * of the project with the following constants:
 *
 * `MAPBOX_ACCESS_TOKEN` - the token for mapbox
 * `MAPBOX_URL_TEMPLATE` the template for mapbox, this can have the default value of
 *      `https://api.tiles.mapbox.com/v4/{id}/{z}/{x}/{y}@2x.png?access_token={accessToken}`
 *
 * In order to have a new key, go to https://www.mapbox.com/ and create a free account
 * and a project for this open-source project
 */

Or you can (for testing purposes) put them both as ""

TomerPacific commented 4 years ago

@Vanethos , I am going to create the file and put both values as empty strings.

Vanethos commented 4 years ago

If I did not break up the git ignore file, then it shouldn't be going to the version control when you try to commit it!

TomerPacific commented 4 years ago

@Vanethos , build is still failing on related issues, even though it runs locally. Any suggestions?

Vanethos commented 4 years ago

@TomerPacific

As I said the keys.dart file should be just added for you locally so if you can remove it from your PR that would be great!

As for Travis we will have to use environment variables for that so that it can build the app, we didn't have time yet for it!

TomerPacific commented 4 years ago

@Vanethos , I removed the keys.dart file