Closed felipeZ closed 3 years ago
Merging #20 (b57371b) into master (dc35819) will increase coverage by
5.36%
. The diff coverage is78.30%
.
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 62.78% 68.15% +5.36%
==========================================
Files 8 8
Lines 352 314 -38
Branches 57 51 -6
==========================================
- Hits 221 214 -7
+ Misses 129 98 -31
Partials 2 2
Impacted Files | Coverage Δ | |
---|---|---|
pyvotca/__version__.py | 100.00% <ø> (ø) |
|
pyvotca/options.py | 82.35% <ø> (ø) |
|
pyvotca/xml_editor.py | 89.47% <ø> (ø) |
|
pyvotca/visualization.py | 28.12% <33.33%> (ø) |
|
pyvotca/numerical_gradient.py | 31.11% <42.85%> (ø) |
|
pyvotca/molecule.py | 82.50% <82.50%> (ø) |
|
pyvotca/xtp/dftgwbse.py | 65.78% <85.71%> (ø) |
|
pyvotca/xtp/__init__.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dc35819...b57371b. Read the comment docs.
While we are renaming everything, can you move the xtp parts into a xtp subclass?
While we are renaming everything, can you move the xtp parts into a xtp subclass?
@junghans I have made xtp
into a submodule encapsulating the XTP functionality that it wraps
While we are renaming everything, can you move the xtp parts into a xtp subclass?
@junghans I have made
xtp
into a submodule encapsulating the XTP functionality that it wraps
Thanks!
Changes
fix #19 by making the module to follow Python conventions