votca / PyVOTCA

Generic tools to interact with Votca using Python
Apache License 2.0
1 stars 1 forks source link

Absorption spectrum with Gaussian lineshape #9

Closed baumeier closed 3 years ago

baumeier commented 3 years ago

Implements #2

codecov[bot] commented 3 years ago

Codecov Report

Merging #9 (9fe9ccc) into master (f4fa2b0) will decrease coverage by 1.67%. The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   25.94%   24.26%   -1.68%     
==========================================
  Files           6        6              
  Lines         212      239      +27     
  Branches       27       31       +4     
==========================================
+ Hits           55       58       +3     
- Misses        157      181      +24     
Impacted Files Coverage Δ
PyVOTCA/wrapper.py 15.05% <0.00%> (-0.68%) :arrow_down:
PyVOTCA/visualization.py 21.62% <13.04%> (-14.10%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f4fa2b0...9fe9ccc. Read the comment docs.

felipeZ commented 3 years ago

@baumeier instead of having hard-coded constant like 27.211, we can use the predefined constant in scipy like:

from scipy.constants import physical_constants 
 h2ev = physical_constants['Hartree energy in eV'][0]
baumeier commented 3 years ago

@felipeZ can you have another look?

felipeZ commented 3 years ago

@baumeier also scipy should be added to the dependencies in the setup.py file

baumeier commented 3 years ago

@baumeier also scipy should be added to the dependencies in the setup.py file

Done.

felipeZ commented 3 years ago

@baumeier I think that we are good to go!