junghans commented 5 years ago

Part of https://github.com/votca/votca/pull/160

crionez commented 5 years ago

You removed GSL and made Eigen3 the only required package. Before I could have either Eigen or GSL linear algebra support, depending on the flag in CMake. Is this restriction really needed?

junghans commented 5 years ago

@crionez, this pull request doesn't touch GSL support, I left it in the exact state as before, GSL support was disabled in https://github.com/votca/ctp/commit/709fd1ab38abcfdec2e008ea8a4e2ee4596b46c4#diff-af3b638bc2a3e6c650974192a53c7291R62.

junghans commented 5 years ago

@crionez see #129 for the GSL issue.

junghans commented 5 years ago

Fix merged that fix, but ctp will still require Eigen3 as it is used everywhere in the votca tools headers.

codecov[bot] commented 5 years ago

Codecov Report

Merging #128 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #128   +/-   ##
======================================
  Coverage     2.3%    2.3%           
======================================
  Files         262     262           
  Lines       43342   43342           
======================================
  Hits         1014    1014           
  Misses      42328   42328

Flag	Coverage Δ
#clang	`1.1% <ø> (ø)`	:arrow_up:
#doxygen	`7.5% <ø> (ø)`	:arrow_up:
#gcc	`1.4% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cf13fa0...ab1b83f. Read the comment docs.

votca / ctp

CMake Refactor in ctp #128

Codecov Report