Closed rubengerritsen closed 3 years ago
@rubengerritsen do you want a review already?
No, a bit to early, let me fix the unit tests and energy evaluation first, then I will press the button for a review. I just made this because I promised to move it from my fork to here last week.
Replaced by https://github.com/votca/votca/pull/847
This is the basis for the ewald implementation. There are still some things to do:
The plan is to add unit tests until everything is covered. I also expect that creating the unit tests will help to resolve the energy evaluation issues that are there currently.