update additional rider information text, position list to right of input

voteamerica / voteamerica.github.io

Front end for the Carpool Vote website. Support every American's right to vote!

http://www.carpoolaction.org/

MIT License

38 stars 50 forks source link

update additional rider information text, position list to right of input #309

Closed tristanmkernan closed 7 years ago

tristanmkernan commented 7 years ago

Motivation

Resolves #305

Changes

[x] moved and updated text
- i did not think that the text wording was quite right, so i changed it - happy to revert the changes
- also updated the placeholder
[x] changed how the list was positioned
- now inline-block, so the list appears to right of input on larger screens

sasjkia commented 7 years ago

I like the look of this, and think it's ready to merge now.

@kylejcrawford for future versions, was there also talk of updating the text inside the actual box?

In any case, it would be good to have this version live this weekend, for the election and the demo on Tues.

richardwestenra commented 7 years ago

@sasjkia The screenshot is my suggestion, it's not showing how the PR currently looks.

@russon77 Let me know whether you want to make that change or whether I should just go ahead and merge.

tristanmkernan commented 7 years ago

@richardwestenra i added the spacing between the two elements :+1: for "pushing down", though, i fear my css-fu is insufficient - so feel free to merge! :fireworks:

richardwestenra commented 7 years ago

@russon77 No worries, I had trouble with that too! Probably an inline-block vertical-alignment thing. I used position:relative & top to move it down, but that's a little hacky. Anyway, sounds good, thanks for this!

kylejcrawford commented 7 years ago

I think this looks great. @richardwestenra @russon77 Would it be fairly simple to update the text within the box?

richardwestenra commented 7 years ago

@kylejcrawford Yes, should be very simple. Add it to an issue (or create a new one) if you have a request.