search

voteamerica / voteamerica.github.io

Front end for the Carpool Vote website. Support every American's right to vote!
http://www.carpoolaction.org/
MIT License
38 stars 50 forks source link

Self-service rider/driver cancellation/pause fixes #320

Closed jkbits1 closed 7 years ago

jkbits1 commented 7 years ago

@richardwestenra this PR provides clear indication of driver and rider cancellations, also driver pause notifications. Status info is added to the rider/driver details and the buttons are changed appropriately. The driver pause notifications button is renamed as requested

Fixes https://github.com/voteamerica/backend/issues/165 Fixes https://github.com/voteamerica/voteamerica.github.io/issues/278

Improves https://github.com/voteamerica/voteamerica.github.io/issues/258

Automated tests pass – the existing tests that test the self service page for match-related behaviour have been extended to test the pause/cancel behaviour.

The automated tests have been enhanced to work with Travis (currently enabled only for my own repos). The 58 valid assertions can be seen here: https://travis-ci.org/jkbits1/voteamerica.github.io/builds/241601319 (give the log a few seconds to load, then scroll to end)

jkbits1 commented 7 years ago

merged as passes automated tests (see comment above)