Closed mikeesto closed 6 years ago
This looks great! Thanks @MichaelE1 :)
I'll test it when I'm able. Overall the code looks very good, and should be fine to merge once I've tested it. In the meantime, I've got two minor suggestions if you feel like actioning them, but no worries if not:
.social a {
display: inline-block;
color: white;
text-decoration: none;
border-radius: 3px;
font-size: 0.6875em;
font-weight: bold;
padding: 5px 6px 3px;
font-family: Helvetica, Arial, sans-serif;
vertical-align: top;
}
.social a:before { content: ''; background-size: contain; width: 16px; height: 12px; display: inline-block; margin: -1px 4px 0 0; vertical-align: top; transform: scale(0.9); }
.social__twitter a { background-color: #00aced; } ....
Then just use the more specific classes for each button for just the specific background colours and images etc. Keeps things DRYer, hence more maintainable and smaller file-size. What do you reckon?
Thanks again!
Thanks for the feedback @richardwestenra . I'll address both your suggestions so hold off merging for now :)
OK it should be good for testing now @richardwestenra . Abstracted the CSS and reduced the sizes of the icons. Thanks.
Resolves #337
Buttons are definitely loading faster, begone slow JS :+1: