Fix header notice width on mobile devices.

voteamerica / voteamerica.github.io

Front end for the Carpool Vote website. Support every American's right to vote!

http://www.carpoolaction.org/

MIT License

38 stars 50 forks source link

Fix header notice width on mobile devices. #398

Closed sndurkin closed 5 years ago

sndurkin commented 5 years ago

Fixes #393.

jkbits1 commented 5 years ago

@sndurkin thanks for fixing this 🙂 I'll review in a day or two

sndurkin commented 5 years ago

@jkbits1 sure thing! I sent an email to slack@carpoolvote.com for an invite to the Slack but haven't heard back yet, is it still active? Also, are there any other beginner issues you can recommend that you'd like to get fixed?

jkbits1 commented 5 years ago

@sndurkin apologies for being slow to respond to this. When I looked at the change to the css, I was going to suggest a media query to support different widths on desktop and mobile. But I’ve just reviewed the PR locally and it looks best as you’ve done it 👍

jkbits1 commented 5 years ago

@sndurkin about the Slack, I’m not sure who’s accepting invites for the channel. You’re very welcome to join us at the partner Slack channel, Carpool Action, although you’ll need to sign up for the Progressive Coders organisation first, at http://progco.de/join